search

ethereum-mining / ethminer

Ethereum miner with OpenCL, CUDA and stratum support
GNU General Public License v3.0
5.97k stars 2.28k forks source link

Cannot compile with CMake #2008

Open MerlinBrasil opened 4 years ago

MerlinBrasil commented 4 years ago

Describe the bug I'm hoping this is something simple, even if just dumb on my part. I'm new to CMake. I just need a very dependable miner!

ethminer errors 2020-07-19_23-25-32

Expected behavior A clear and concise description of what you expected to happen. Well..... I thought the CMake should work and compile.

Environment (please complete the following information):

AndreaLanfranchi commented 4 years ago

It seems to me you have not updated submodules: you have only cloned the project. Read this https://github.com/ethereum-mining/ethminer/blob/master/docs/BUILD.md#instructions

Eventually however you won't be able to compile as you'll get a Hunter error. Currently implemented version of Hunter does not recognize VS 2019

MerlinBrasil commented 4 years ago

Thank you, Andrea :)

So, until Hunter catches up, there's no point in me playing with this? As 2019 has been out for ages now, and there's a free Community version, why haven't they caught up by now?

Thanks again, Merlin

AndreaLanfranchi commented 4 years ago

Maybe this discussion can help understand why https://github.com/ethereum-mining/ethminer/issues/1914

Consider this project only randomly updated without any roadmap.

Edit : It's not Hunter not reckoning VS2019. Latest Hunter releases do. Is this project still relying on an old version if Hunter.

MerlinBrasil commented 4 years ago

Hi Andrea, Yes... #1914 told the story, and a sad one it was. I started my career programming in 1977, so it's not hard for me to feel your pain.

Some nice stuff has come out of Open Source, but I suspected there was a downside ;)

What do you think it would take to get this project back on track? Is adjusting the code to fit current Hunter version the final item for now? I'm happy to contribute, if I can, to the coding side of things, but I'm not sure my coding skills are up to the task. In theory, if this thing is running and producing Eth (which has value) I see no reason why not to be able to contribute to the project financially. There does seem to be a solid niche market for it.

Your opinion?

Thanks, Merlin

AndreaLanfranchi commented 4 years ago

Hunter upgrade is the least problem. To adjust it is trivial. Honestly I don't see a future for open source ethminer for various reasons : the main one is roadmap to PoS. But besides this there is lack of a solid leadership in this project (currently the owner of this repo is missing since long time) and a decent funding plan. But even in this case it'd be a waste of time as all (I underline all) closed source software do steal code from here and (thank to their obscurity) cheat on produced hashrate : by consequences all users go for closed source devfee. In all of that the FSF doesn't have the power (or the willing) to sue anyone.

So why bother with continuous implementation ?

MerlinBrasil commented 4 years ago

"So why bother with continuous implementation?"

There may be a very simple answer to that, Andre. Referring back to the early Greek and Roman Stoics.... because it's the RIGHT thing to do. Yes, people will steal. Nothing really you can do about that ever. HOW you react to that, however, is up to YOU. Only you can decide what's right, and I think if you'd divorced yourself from this project you wouldn't have bothered to follow the threads and responded to my question. So... you're involved.

If the current owner is missing or dead, can you not take the project over yourself? Obviously, you care. DO somETHing about it :)

I have NO problems with contributing back a % and I have no problem with you inserting that particular % into the Open Source code. To me, that's fair and equitable for both of us. I have a very very powerful laptop and wish to mine with it, especially with my RTX 2080. Hot CPU as well :) But I need to be able to compile here as I don't trust the Closed Source thieves any more than you do. For me, doing that right thing defeats them, to a degree. I'm happy to let Karma take care of them later!

Right now, neither of us are making anything. Let's change that.

Best regards, Merlin

AndreaLanfranchi commented 4 years ago

Referring back to the early Greek and Roman Stoics.... because it's the RIGHT thing to do [...] Right now, neither of us are making anything. Let's change that.

I've already done my part during last two years. I know of @jean-m-cyr still working on some issues related to 4+Gb of DAG usage and recently he solved a problem for OpenCL memory allocation on AMD cards. In addition to that I've done on a separate repo a lot of work implementing ProgPoW which I eventually withdrawn due to frustration caused by the project: a concrete part of that work is (I believe) still maintained by @jean-m-cyr in his repository

Besides that I reply to some issues from time to time cause being listed among contribs and having the right to review PRs I still receive emails from this repo. But is something I do without a precise cadence.

Yes you're right ... I still care ... like you'd care for anything you've worked on a lot. You hoped your child had legs to make its own way ... but no. Nevertheless this does not allow me to spend any more time on the project: my spare time is very limited and obviously I must work on paid projects (my bills have to be paid and I have to put food on my family's table).

I honestly share your passion but ... that alone is not enough. Let's be realistic: a project like this can't survive on behalf of few private miners which may decide to keep the devfee (while the vast majority would recompile with devfee removed).

I have a very very powerful laptop and wish to mine with it, especially with my RTX 2080.

At current prices your machine would mint $2.30 worth of eth per day (not counting the power bill). Do you really think, assuming a 1% devfee, 6$ per year would change anything ? Would need at least 10k users like you to have a spark calling to action at least a couple of devs part-time.

Anyway ... this code is public and anyone can fork it. Maybe you'll have better luck than me trying to gather valuable contributors.

Best.

MerlinBrasil commented 4 years ago

First. Andrea, $2.30 x 365 = 839.50 I'm on solar power, so now my electric bill is a non-factor..

Second, the value of code I can read and trust is worth more to me. If I only set that variable to .05, I'm still gaining nearly $800 per year that I would not have had otherwise. Two of 'me' would eclipse your reported $65 per year, and perhaps there are more like me. If I see viability and increase my solar, I may increase my hardware, as well. I'm not greedy. I like to play games where everybody wins. I just choose crypto for this game.

There is no "I have done enough" in "Doing the Right Thing" but only you know what the right thing is. If spending a few hours, if that, updating the code so that it can easily be compiled and run, isn't 'right' for you, then forget it. The thing is, considering the Butterfly Effect, you cannot know what positive effects your good efforts can produce. Whining ab=out the thieves, to zero effect can't be the right thing. That produces no good effects in the universe and simply makes you feel bad.

AndreaLanfranchi commented 4 years ago

Whining ab=out the thieves, to zero effect can't be the right thing

I'm not whinig. This is latin : "Si non potes inimicum tuum vincere, habeas eum amicum". I simply moved away from helping others in crypto for free. In this specific case we're talking "miners" ... not people who's starving in underdeveloped countries. Any principle of mutual support, decentralization, and cohoperation in crypto is long time dead. Every single individual involved is doing this for money (unless they're developers enjoiying their retirement ... I'm not - unfortunately - one of those)

I am sorry if this conflicts with your vision ... this is my personal point. Eventually there were other developers involved into this project ... but as you can see nobody is answering since long time.

Two of 'me' would eclipse your reported $65 per year

I was referring to the possible income of a devfee ... 65$ barely cover one hour of work of a dev.

MerlinBrasil commented 4 years ago

Funny.... "If you can't beat them, join them".... not exactly a Warrior's Creed.

And, yes, you very much whining, but just covering it in self-righteous justifications. Doesn't make you right, just weak.

But, if you're determined to join the other quitters, then so be it. Certainly your right to choose. I see no point in further trying to appeal to your better nature. Old men don't like to be challenged, but thanks for the discussion.

AndreaLanfranchi commented 4 years ago

Funny.... "If you can't beat them, join them".... not exactly a Warrior's Creed.

"Only" Julius Caesar

but thanks for the discussion.

You're welcome ... keeping open the issue just for reference but won't add further comments.

StefanOberhumer commented 4 years ago

@MerlinBrasil I also reduced my time on this project as I came to the point where I found out most of the "non-free" mining softwares use parts of code from ethminer or Genoil's miner are at least based on those projects and I'm now using my own optimized version.

What amounts we're talking about? Starting a calculation (using a blocktime of 15 secs and ignoring tx fees / uncles) generates 2102400 blocks per year. Bringing that to reward numbers is: ETH: 4,204,800 ETH reward / year [@2.0ETH/block] ETC: 6,727,680 ETC reward / year [@3.2ETC/block]

In money this would mean you're talking about: 1,051,200,000 USD (ETH @ 250.0 USD) 41,711,616 USD (ETC @6.2 USD)

If you take 1% for the mining software developers you're talking about a devfee-market of minimum: 10.929.116 USD/year .

As a non paid developer on ethminer you get the the feeling that a lot of your spent time gets paid to the "big commercial players" due to better marketing/stats-fake. Also see: https://hiveos.farm/statistics ( as a sample for a split of minig software used )

Spending:

for free got (I think) most of us a little bit frustrated.

Sorry to say - my opinion: Nobody is interested keeping this project alive. :disappointed:

AndreaLanfranchi commented 4 years ago

@StefanOberhumer @MerlinBrasil one last (very last addition).

I quote here a statement from @jean-m-cyr written on another channel (hope he doesn't mind):

I've been in touch with the FSF about rampant violations by mining concerns. Their response was (I paraphrase): Given the shit hole the Internet has become, with entities hiding behind ever changing fake accounts and cute (read stupid) avatars, it has become exceedingly difficult and costly bringing them to trial.

jean-m-cyr commented 4 years ago

No, I don't mind at all. I would however like to see one final release of Ethminer just to cap off the project. There are a number of good fixes in the queue, and evidently some folks are still mining out of nostalgia. I'd do the work of reviewing and merging but I long ago relinquished my role as collaborator. @chfast would also need to do the final release steps (tagging, release items, etc).

jean-m-cyr commented 4 years ago

@StefanOberhumer @AndreaLanfranchi @chfast "Farewell, and thanks for all the fish."

StefanOberhumer commented 4 years ago

@StefanOberhumer @AndreaLanfranchi @chfast "Farewell, and thanks for all the fish."

@jean-m-cyr 42 :wink:

chfast commented 4 years ago

No, I don't mind at all. I would however like to see one final release of Ethminer just to cap off the project. There are a number of good fixes in the queue, and evidently some folks are still mining out of nostalgia. I'd do the work of reviewing and merging but I long ago relinquished my role as collaborator. @chfast would also need to do the final release steps (tagging, release items, etc).

I can make a new release. Is everything in master?

jean-m-cyr commented 4 years ago

@chfast There's a couple of un-merged PRs that should go in first. Give me collaborator and I can clean that up.

MerlinBrasil commented 4 years ago

Very glad to see this project still has some life in it.

Much appreciated :)

Best, Merlin

On Tue, Jul 28, 2020 at 1:13 PM Jean Cyr notifications@github.com wrote:

@chfast https://github.com/chfast There's a couple of un-merged PRs that should go in first. Give me collaborator and I can clean that up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ethereum-mining/ethminer/issues/2008#issuecomment-665133627, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJYI3DQ6MGBPIOIQEZT6WDR532L7ANCNFSM4PDBDF7A .

MerlinBrasil commented 4 years ago

@jean-m-cyr

Any motion on this?

Best, Merlin

jean-m-cyr commented 4 years ago

@MerlinBrasil Motion? The last few updates have been merged and the final cut has been released. I don't expect you'll see any further 'motion' here. What would be the point?

hotslice commented 3 years ago

FWIW I was able to build from within "Developer Command Prompt for VS2019 Preview" just fine. I don't have VS2017 installed on my machine. It complained with warnings about not being able to find VS2017 a few times, but didn't fail. Just followed the default build instructions and didn't have to do anything special, other than installing Perl and CUDA toolkit.