ethereum-oasis-op / baseline

The Baseline Protocol is an open source initiative that combines advances in cryptography, messaging, and distributed ledger technology to enable confidential and complex coordination between enterprises while keeping data in systems of record. This repo serves as the main repo for the Baseline Protocol, containing core packages, examples, and reference implementations.
https://docs.baseline-protocol.org
Other
576 stars 237 forks source link

[SRI] enable cors setting #593

Open Manik-Jain opened 1 year ago

Manik-Jain commented 1 year ago

Overview

We need to make sure that the CORS is enabled properly before we move to PROD.

Tasks

change in main.ts the cors settings

ognjenkurtic commented 1 year ago

Could you please describe in more detail what does it mean to have CORS enabled properly and how will the completion of this issue be tested?

Kasshern commented 1 year ago

I think enabled properly here means that the cors setting only allow exactly our expectations within requests - Testing could be run through calls that adhere or not to cors expectations. See more here https://github.com/expressjs/cors#configuration-options