search

ethereum-optimism / batch-submitter

[Optimism] Batches go zoom
12 stars 16 forks source link

Use unit (ms, s) when variable refers to time #49

Open smartcontracts opened 3 years ago

smartcontracts commented 3 years ago

Let's heed @snario's suggestion and switch over the variables to include the unit. Great first issue for anyone who wants to contribute!

Something I've found useful in the past is to add the unit as a suffix to the variable name. e.g.,

  • MAX_BATCH_SUBMISSION_TIME_S
  • POLL_INTERVAL_MS

Originally posted by @snario in https://github.com/ethereum-optimism/batch-submitter/pull/7#r585682849

walkingbackward commented 3 years ago

I would like to contribute. New to github; how would the changes need to be made?

platocrat commented 3 years ago

how would the changes need to be made?

I think you should use the suggestion snario made in his comment from his code review in #7 (comment)

walkingbackward commented 3 years ago

Created a pull request with changes. Are there other examples of time to look for? I.e. Timeout to timeouts?

smartcontracts commented 3 years ago

@walkingbackward I'll take a quick look at the codebase to see if there's anything else. Thank you!!! Awesome work :-)