search

ethereum-optimism / core-utils

[Optimism] Various useful utilities.
MIT License
1 stars 7 forks source link

refactor: move utils #8

Closed platocrat closed 3 years ago

platocrat commented 3 years ago

Moved utils from data-transport-layer/src/utils/common.ts to core-utils/src/common/common.ts.

platocrat commented 3 years ago

final addition of utils from this recent merged PR: https://github.com/ethereum-optimism/data-transport-layer/pull/40

platocrat commented 3 years ago

Sorry, it took me so long!

I messed a ton of stuff up and had to figure out how to resolve it. Ended up git hard resetting back to my most recent commit (which was somehow painful to find 😅) in this PR

platocrat commented 3 years ago

What I was trying to proactively fix was the merge conflict that's going to occur when the merge is attempted.

I failed by trying to clone a recent copy of ethereum-optimism/core-utils, change the remote URL to my fork, checkout of a new version of the refactor/move-utils branch, and copy over all my changes from this PR and push that.

Didn't work out for various reasons...

platocrat commented 3 years ago

That merge fixes everything. Sorry again for taking so long 😕

smartcontracts commented 3 years ago

Awesome work here :-)

tynes commented 3 years ago

I added a test here: https://github.com/platocrat/core-utils/pull/1 Once you merge that, then we can merge over here