search

ethereum-optimism / design-docs

MIT License
26 stars 20 forks source link

feat: fma-generic-contracts #140

Closed refcell closed 3 weeks ago

refcell commented 1 month ago

Description

Introduces an fma-generic-contracts.md document in the security directory covering contract upgrades.

This was asked for by @mds1 as part of Stage 1.4 FMA review in https://github.com/ethereum-optimism/design-docs/pull/132.

These generic items were ported from notion.

tynes commented 3 weeks ago

This looks good to me given https://github.com/ethereum-optimism/design-docs/pull/140/files#r1820743365 is addressed by deleting that section and making sure that we have a generic contract upgrade failure mode, which I do believe that is already covered in this document with the other failure modes, cannot think of another generic contract upgrade failure mode unless i start to stretch like upgrade reverts/oog or something like that

refcell commented 3 weeks ago

FYI: I've updated https://github.com/ethereum-optimism/design-docs/pull/132 with the reference to DisputeGameFactory.setImplementation in fma-generic-hardforks.md 😄