search

ethereum-optimism / design-docs

MIT License
26 stars 20 forks source link

Change `DeputyGuardianModule` to use a Proxy to be `DeputyGuardianModuleProxy` #89

Closed Ethnical closed 1 month ago

Ethnical commented 2 months ago

Introduce a proposal that will prevent to regenerate the PSPs and make some unnecessary changes to the guardian contract each time we update the DeputyGuardianModule code. As discussed here on discord.

Ethnical commented 1 month ago

It appears that we'll never have a need to destroy or replace a PSP. If not, when could that happens? @Inphi Good point, I will highlight the way to have invalidated PSPs into the new system.

  1. The first cause of invalidated the PSPs is Nonces of the FoS increase too much so made monitoring for this op-defender and oncall should be aware about it.
  2. If there is breaking changes on the smart contracts on L1. For example, the SuperchainConfig is updated. Or the Guardian overwrite the list of the modules that can execute action. Really unlikely, but worth noting.
Ethnical commented 1 month ago

I have merged the change for the gap PSPs: https://github.com/ethereum-optimism/superchain-ops/pull/347 Also, Eli told us this is not suppose the cause issue with l2beat so we are good to merge this final doc review.