Closed astro44 closed 1 month ago
@astro44 was this done on the tutorials/chain
branch?
@astro44 was this done on the
tutorials/chain
branch?
I found the same problem, the link you send was done on tutorials/chan
branch,the problem is on v1.7.0, there's a lot of difference.
I think the tutorials/chain
branch should keep up with the latest stable version.
On v1.7.0 branch ,there are several points not consistent with the current tutorials/chain
branch:
--l1-deployments ../packages/contracts-bedrock/deployments/getting-started/.deploy
instead of --deployment-dir
--l1.beacon=xxx
--l2oo-address
,like --l2oo-address= $(cat ../packages/contracts-bedrock/deployments/getting-started/.deploy | jq -r '.L2OutputOracleProxy')
@astro44 was this done on the
tutorials/chain
branch?
I have another question:
I think the contracts on branch op-contracts/xxx
was audited, right ?
How about the contracts on branch tutorials/chain
?
Sorry @luleigreat, @sbvegan somehow didn't see this thread, I didn't actually make any changes so this isn't on any branch, I just made the "suggestion" here in the ticket. @luleigreat: I don't know if they were audited, I would assume so.... but thats a question for someone within Optimisim to answer... maybe @sbvegan can help?
closing in favor of https://github.com/ethereum-optimism/docs/issues/917
Please update docs to reflect latest changes in new builds. since version 1.7.0 hardhat artifacts are no longer used in a few places in the build / run process: https://github.com/ethereum-optimism/optimism/commit/082d075dcef809ebb940129ff17de8b0f5ec3451 main.go call will need to be changed... currently in the tutorial:
but should look more like: go run cmd/main.go genesis l2 \ --deploy-config ../packages/contracts-bedrock/deploy-config/getting-started.json \ --l1-deployments ../packages/contracts-bedrock/deployments/getting-started/.deploy \ --outfile.l2 genesis.json \ --outfile.rollup rollup.json \ --l1-rpc $L1_RPC_URL
also any references to json files in getting-started should likely require the contents of .deploy. so for running proposer:
should look more like: for -l2oo-address... in () cat ../packages/contracts-bedrock/deployments/getting-started/.deploy | jq -r '.L2OutputOracleProxy'
and also:
again... we'll find the address in the .deploy file mentioned above.