search

ethereum-optimism / op-geth

GNU Lesser General Public License v3.0
254 stars 652 forks source link

chore: update dependency on superchain-registry #300

Closed geoknee closed 1 month ago

geoknee commented 2 months ago

This is just a sanity check against changes from this unmerged PR https://github.com/ethereum-optimism/superchain-registry/pull/190.

It also pulls in other changes which are currently causing tests to fail here.

geoknee commented 2 months ago

Looks like we have some genuine failures here related to genesis hash checking. Will investigate.

geoknee commented 2 months ago 
=== RUN   TestOPStackGenesis

    /Users/georgeknee/code/ethereum-optimism/op-geth/core/superchain_test.go:16: chainID=1740: produced genesis with hash 0x71d15fcf37d911d63f8738f1fde1b03cc7ff5b06ccd9331deb322aee76f35f38 but expected 0xd24cf8e46b189b0c128dab4e46168520e3a4cdd390b239e8cc1e5abd22a629ae

    /Users/georgeknee/code/ethereum-optimism/op-geth/core/superchain_test.go:16: chainID=8866: produced genesis with hash 0x3428b729cf29e0ef5e94c681ea63d6e65fb80a733e705b6e0dbf06561c0bc939 but expected 0x01711dc53a82967a34f4b38f7dff3ae8fa760882bb1e2ace50bb01e9ff420a9b

These are chains which currently have the genesis hash check skipped in the superchain-registry https://github.com/ethereum-optimism/superchain-registry/issues/178

geoknee commented 2 months ago

Also related to https://github.com/ethereum-optimism/superchain-registry/issues/78. The check is duplicated in superchain-registry, only there it has exclusions and here it does not.