search

ethereum-optimism / op-geth

GNU Lesser General Public License v3.0
254 stars 652 forks source link

remove unused `disableTxPool` #325

Closed zhiqiangxu closed 3 weeks ago

zhiqiangxu commented 4 weeks ago

disableTxPool is added 9 month ago, always false, so it's safe to remove it.

trianglesphere commented 4 weeks ago

This is set with a flag (though the logic is more complex). Please explain why the full logic means that this config is not helpful.

Generally disableTxPool = true is the desired behavior for local nodes

zhiqiangxu commented 4 weeks ago

This is set with a flag (though the logic is more complex). Please explain why the full logic means that this config is not helpful.

Generally disableTxPool = true is the desired behavior for local nodes

Hello @trianglesphere I checked again, this variable is never changed. Only RollupDisableTxPoolGossip is changed, but it's a different variable.

zhiqiangxu commented 3 weeks ago

Oops, @trianglesphere you're right, it turns out vscode somehow doesn't show the assignment for disableTxPool here.

I fired an issue for vscode-go.