search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.65k stars 3.28k forks source link

challenger: Deduplicate code between cannon and asterisc integrations #10652

Closed ajsutton closed 1 month ago

ajsutton commented 5 months ago

There is a significant amount of shared code between the cannon and asterisc trace provider types that we should look to deduplicate. In particular around snapshot and prestate management.

We should work through this in small steps, not try to deduplicate everything at once. Likely need a shared module (currently have some shared code in util but that's not a great name).

estensen commented 5 months ago

I would love to work on this

ajsutton commented 1 month ago

Closing this - we've deduplicated a lot of the code and I think it's generally got a good balance between avoiding duplicate code and yet not conflating different concepts which happen to be able to share code currently. The balance is definitely not set in stone, but we don't need to track this as an issue to work on now.