search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.21k stars 2.99k forks source link

add deploy-config/mainnet.json and deploy-config/sepolia.json to @eth-optimism/contracts-bedrock package #11039

Closed raffaele-oplabs closed 3 days ago

raffaele-oplabs commented 3 days ago

Description

At the moment the package @eth-optimism/contracts-bedrock does not include deploy-config folder configurations. We are using them in some of the monitoring program we are using in chain-mon. In order to move chain-mon to monitorism repository we need to first make sure all monitoring we have keep working after we move. At the moment two of these monitoring script make use of deploy-config/mainnet.json and deploy-config/sepolia.json.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.44%. Comparing base (cce7f9c) to head (fb1481f).

:exclamation: There is a different number of reports uploaded between BASE (cce7f9c) and HEAD (fb1481f). Click for more details.

HEAD has 2 uploads less than BASE | Flag | BASE (cce7f9c) | HEAD (fb1481f) | |------|------|------| |chain-mon-tests|2|1| |sdk-tests|2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #11039 +/- ## ============================================ - Coverage 60.69% 16.44% -44.25% ============================================ Files 20 8 -12 Lines 1781 535 -1246 Branches 71 71 ============================================ - Hits 1081 88 -993 + Misses 667 447 -220 + Partials 33 0 -33 ``` | [Flag](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/11039/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | Coverage Δ | | |---|---|---| | [cannon-go-tests](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/11039/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `?` | | | [chain-mon-tests](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/11039/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `27.14% <ø> (ø)` | | | [sdk-tests](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/11039/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `16.44% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism#carryforward-flags-in-the-pull-request-comment) to find out more. [see 12 files with indirect coverage changes](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/11039/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism)
tynes commented 3 days ago

Since we do not publish contracts-bedrock to npm, this isn't the ideal solution