ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.65k stars 3.28k forks source link

cannon: Add more robust validation in Cannon fuzz tests #11651

Closed mbaxter closed 1 month ago

mbaxter commented 2 months ago

Description

Following up on https://github.com/ethereum-optimism/optimism/issues/11634, there are a few fuzz tests that don't fully validate the post-state updates on the FPVMState. Creating this ticket to address some TODOs added in ethereum-optimism/optimism#11634 to make these tests more robust.

TODOs can be seen here: https://github.com/ethereum-optimism/optimism/pull/11573/commits/b9917d6459559e4ed6e3dd7eb1c7c6016d3885b0

Inphi commented 2 months ago

We've knocked off a couple of todos. Is this still needed?

mbaxter commented 2 months ago

Yeah, we should go ahead and finish cleaning this up - I can have a look.