ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.56k stars 3.22k forks source link

Interop: early draft of tracker of recent safety data #12058

Closed protolambda closed 3 days ago

protolambda commented 6 days ago

Description

Early draft. Some op-node changes will be required, to make the interop deriver emit local safety changes, and L1 finality signals, to the op-supervisor.

Tests

Work in progress

Additional context

Metadata

Fix https://github.com/ethereum-optimism/optimism/issues/12042

semgrep-app[bot] commented 6 days ago

Semgrep found 1 sol-style-return-arg-fmt finding:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

#

Semgrep found 8 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

#

Semgrep found 1 leaky-time-after finding:

Leaky use of time.After in for-select, see: https://groups.google.com/g/golang-nuts/c/cCdm0Ixwi9A/m/jMiJJScAEAAJ

Ignore this finding from leaky-time-after.

#

Semgrep found 1 marshal-json-pointer-receiver finding:

MarshalJSON with a pointer receiver has surprising results: https://github.com/golang/go/issues/22967

Ignore this finding from marshal-json-pointer-receiver.

semgrep-app[bot] commented 5 days ago

Semgrep found 1 sol-style-return-arg-fmt finding:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

#

Semgrep found 10 sol-style-input-arg-fmt findings:

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.