Open mslipper opened 6 days ago
Semgrep found 35 sol-style-return-arg-fmt
findings:
Named return arguments to functions must be appended with an underscore (_
)
Ignore this finding from sol-style-return-arg-fmt.
#
Semgrep found 44 sol-style-input-arg-fmt
findings:
Inputs to functions must be prepended with an underscore (_
)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #12059 +/- ## ======================================== Coverage 74.97% 74.97% ======================================== Files 49 49 Lines 3656 3656 ======================================== Hits 2741 2741 Misses 743 743 Partials 172 172 ``` | [Flag](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12059/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | Coverage Δ | | |---|---|---| | [cannon-go-tests](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12059/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `74.97% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism#carryforward-flags-in-the-pull-request-comment) to find out more.