search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.56k stars 3.22k forks source link

cannon: Drop unnecessary wakeup field reset #12095

Closed mbaxter closed 5 days ago

mbaxter commented 5 days ago

Description

Cut unnecessary wakeup reset logic.

Tests

Existing tests should provide coverage.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.86%. Comparing base (8b76931) to head (c48d154). Report is 6 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #12095 +/- ## =========================================== - Coverage 78.87% 78.86% -0.02% =========================================== Files 41 41 Lines 3437 3435 -2 =========================================== - Hits 2711 2709 -2 Misses 557 557 Partials 169 169 ``` | [Flag](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12095/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | Coverage Δ | | |---|---|---| | [cannon-go-tests](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12095/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `78.86% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12095?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | Coverage Δ | | |---|---|---| | [cannon/mipsevm/multithreaded/mips.go](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12095?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Fmultithreaded%2Fmips.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism#diff-Y2Fubm9uL21pcHNldm0vbXVsdGl0aHJlYWRlZC9taXBzLmdv) | `95.67% <100.00%> (-0.03%)` | :arrow_down: |