search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.56k stars 3.22k forks source link

op-e2e: Expose honestActorConfig public for Asterisc testing #12108

Closed mininny closed 4 days ago

mininny commented 4 days ago

Description We need to make HonestActorConfig public for Asterisc's op-e2e tests so that the e2eutils can be properly overriden in Asterisc.

Relevant diff in Asterisc's WIP PR: https://github.com/ethereum-optimism/asterisc/blob/65d9c4f0c6c71fbfa31e617dbb6fda9c9ddc8c0b/op-e2e/e2eutils/disputegame/output_asterisc_helper.go#L58-L83

ajsutton commented 4 days ago

@mininny For some reason CI didn't trigger, could you try rebasing on develop to give it a kick and see if that's enough to get it working please?

mininny commented 4 days ago

@mininny For some reason CI didn't trigger, could you try rebasing on develop to give it a kick and see if that's enough to get it working please?

Done! Thanks for the review :)

ajsutton commented 4 days ago

@mininny I'm guessing that's a flake on the devnet-altda tests but it ran in testinprod's org on circleci so I can't rerun from failed. Can you give it a kick please? Sorry for the hassle.

mininny commented 4 days ago

@mininny I'm guessing that's a flake on the devnet-altda tests but it ran in testinprod's org on circleci so I can't rerun from failed. Can you give it a kick please? Sorry for the hassle.

It's succeeded now :) No problem, thanks helping!