search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.65k stars 3.28k forks source link

Holocene-D: op-batcher: Investigate persistence #12126

Closed sebastianst closed 2 weeks ago

sebastianst commented 1 month ago

Depending on the outcome of our batcher hardening investigations in https://github.com/ethereum-optimism/optimism/issues/12123 we might conclude that we want to implement some sort of persistence for the batcher and/or txmgr.

At this point I lean to not do this, and instead live with possibly sending duplicate data after restarts. We already have the past batcher tx check at startup, so this is a super rare case to hit in practice anyways, where there are pending batcher transactions in the global mempool. Individual batcher transactions are cheap enough that it's probably not worth the extra effort and complexity to add persistence.

geoknee commented 2 weeks ago

I agree that it doesn't seem worth breaking the statelessness of the batcher for this.