search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.65k stars 3.28k forks source link

chore: solidity isthmus to interop #12132

Closed 0xDiscotech closed 1 month ago

0xDiscotech commented 1 month ago

Description

Rename L1BlockIsthmus to L1BlockInterop for consistency with the upgrade naming. The scope of it is only the Solidity files, there will be another one with the changes on the Golang files because that's how it was asked from reviewers.

Tests

I added no tests, but only modified the contracts name so they don' break

Additional context PR with the Golang files renaming changes: https://github.com/ethereum-optimism/optimism/pull/12133

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.94%. Comparing base (3210a8c) to head (adad651). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #12132 +/- ## ======================================== Coverage 74.94% 74.94% ======================================== Files 49 49 Lines 3652 3652 ======================================== Hits 2737 2737 Misses 743 743 Partials 172 172 ``` | [Flag](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12132/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | Coverage Δ | | |---|---|---| | [cannon-go-tests](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12132/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `74.94% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism#carryforward-flags-in-the-pull-request-comment) to find out more.
protolambda commented 1 month ago

Github complains about a merge conflict, but local merge with develop is fine. And I don't have push-access to this branch to add a merge commit. Can you update this, so we can merge into develop? Thank you!