search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.6k stars 3.24k forks source link

make test-unit fails locally on develop branch #12394

Open samlaf opened 1 week ago

samlaf commented 1 week ago

Bug Description

Running make test-unit fails locally. Is this normal? Getting

    supersystem.go:165: 
                Error Trace:    /Users/samlaf/devel/eigenlayer/da-integrations/optimism/op-e2e/interop/supersystem.go:165
                                                        /Users/samlaf/devel/eigenlayer/da-integrations/optimism/op-e2e/interop/supersystem.go:476
                                                        /Users/samlaf/devel/eigenlayer/da-integrations/optimism/op-e2e/interop/supersystem.go:102
                                                        /Users/samlaf/devel/eigenlayer/da-integrations/optimism/op-e2e/interop/interop_test.go:35
                Error:          Received unexpected error:
                                failed to deploy L2 1374395966400 to L1: failed to deploy L2 OP chain: failed to load DeployOPChain script: could not load script artifact: failed to open artifact "DeployOPChain.s.sol/DeployOPChain.json": open DeployOPChain.s.sol/DeployOPChain.json: no such file or directory
                Test:           TestInteropTrivial
--- FAIL: TestInteropTrivial (0.15s)
FAIL
FAIL    github.com/ethereum-optimism/optimism/op-e2e/interop    0.382s
FAIL

Steps to Reproduce

Expected behavior

Environment Information:

Configurations:

Logs:

Additional context

using develop branch

⚠️ Notice: Issues that do not include the following sections will be subject to closure:

Please ensure all required sections are filled out accurately to expedite the debugging process and improve issue resolution efficiency.

smartcontracts commented 1 week ago

Hmmm can you try running make build first?

samlaf commented 1 day ago

Running make build gives me

forge fmt || true
forge build
[⠰] Compiling...
[⠔] Compiling 38 files with Solc 0.8.25
[⠒] Compiling 143 files with Solc 0.8.15
[⠑] Compiling 2 files with Solc 0.8.19
[⠑] Solc 0.8.19 finished in 932.70ms
[⠑] Solc 0.8.25 finished in 6.12s
[⠔] Solc 0.8.15 finished in 225.74s
Compiler run successful!
go run ./scripts/checks/interfaces
❌  MintableAndBurnable: Interface does not start with 'I'
❌  MintableAndBurnable: Interface does not have correct compiler version (MUST be exactly solidity ^0.8.0)
❌  IL1FeeVault: Differences found in ABI between interface and actual contract
an error occurred: interface check failed, see logs above
exit status 1
error: Recipe `interfaces-check-no-build` failed on line 143 with exit code 1
make: *** [build-contracts] Error 1

Even tried make clean and still same result. Is there some precondition command I should be running or something..?

smartcontracts commented 1 day ago

Hmm I've seen this before, can you try cd packages/contracts-bedrock && just clean and then try make build in the root one more time?