ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.67k stars 3.31k forks source link

feat(ctb): Vendor `RISCV.sol` #12994

Closed clabby closed 6 days ago

clabby commented 6 days ago

Overview

Vendors the RISCV.sol contract from asterisc into the monorepo. The source contract, and its tests (as they are still dependent on the native asterisc VM), will continue to live over in asterisc. When we need to perform an upgrade involving this contract, changes will be upstreamed.

This is to make the integration of asterisc into op-deployer and the standard upgrade process less painful. Longer term, we will think about ways to enable use of other repositories' contracts.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.77%. Comparing base (b824f9b) to head (e337bad). Report is 5 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #12994 +/- ## =========================================== - Coverage 68.78% 66.77% -2.02% =========================================== Files 56 56 Lines 4665 4665 =========================================== - Hits 3209 3115 -94 - Misses 1274 1378 +104 + Partials 182 172 -10 ``` | [Flag](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12994/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | Coverage Δ | | |---|---|---| | [cannon-go-tests-32](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `61.85% <ø> (-2.02%)` | :arrow_down: | | [cannon-go-tests-64](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism) | `56.72% <ø> (-1.66%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism#carryforward-flags-in-the-pull-request-comment) to find out more. [see 8 files with indirect coverage changes](https://app.codecov.io/gh/ethereum-optimism/optimism/pull/12994/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum-optimism)

🚨 Try these New Features:

clabby commented 6 days ago

Passing scheduled job: https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/72358/workflows/86b96b01-9c4e-41d2-8550-d6d98ffa4b83