ethereum-optimism / optimism

Optimism is Ethereum, scaled.

https://optimism.io

MIT License

5.65k stars 3.29k forks source link

Building `smock` in CI fails #554

Closed tynes closed 3 years ago

tynes commented 3 years ago

Describe the bug There is an unrelated bug happening in https://github.com/ethereum-optimism/optimism/pull/544

Error: src/smockit/binding.ts(2,43): error TS2307: Cannot find module 
'hardhat/internal/hardhat-network/provider/errors' or its corresponding type declarations.

To Reproduce Look at the failing tests, the log show that smock fails to build. https://github.com/ethereum-optimism/optimism/pull/544

Expected behavior smock should build without a problem

smoove commented 3 years ago

Any workarounds for the time being? The file 'hardhat/internal/hardhat-network/provider/errors' was indeed removed from hardhat-core.

smartcontracts commented 3 years ago

Checking this out

smartcontracts commented 3 years ago

Working on this over at #576

smartcontracts commented 3 years ago

576 was merged. Can we check if this is still happening?

gakonst commented 3 years ago

I cannot repro this any more, it was published in https://github.com/ethereum-optimism/optimism/pull/582. If anyone still encounters it, please reopen