search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.53k stars 3.19k forks source link

Unknown gnosis safe error in the recent deployment code #7484

Closed Chomtana closed 11 months ago

Chomtana commented 11 months ago

Describe the bug

A developer has experienced this issue and ask for the help in Discord

    ├─ [0] VM::serializeAddress(<stringified JSON>, SafeProxyFactory, 0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2) 
    │   └─ ← {"AddressManager":"0x14D06Eff9fB3f322eeB10FbD4A4f41CE0112A421","L1CrossDomainMessenger":"0x0D264fD80cf0dA2882aC97315DD03f5F640Da230","L1CrossDomainMessengerProxy":"0x6299aF8bC19D31902d6d5c011d73bE42252D146f","L1ERC721Bridge":"0x6E22E0C6787205BdBC043bdaf1A66d43055341Da","L1ERC721BridgeProxy":"0x4fa6415F46B91D8C2E6e2aac660D8c8447aD5b46","L1StandardBridge":"0xe51c06F292E35EB501F1D18bfB5Df381bdd9ffC3","L1StandardBridgeProxy":"0xf3dA0f847332a427a1ce437f9410C9f15ac273DF","L2OutputOracle":"0xB6827f3AFd9D51A6F8307ae9940b4b6209d4E1b5","L2OutputOracleProxy":"0x6F8949A268ad96F56D1dFbD515e6f28dba15C590","OptimismMintableERC20Factory":"0x5c49F95cA0Fb439D663C062029EE56164146e731","OptimismMintableERC20FactoryProxy":"0xA15f8Bc2A424238d4157de19645C86c90fa2F558","OptimismPortal":"0x559a402d0cF60A38Fe9C948182c7CA2BBf30c9e8","OptimismPortalProxy":"0xe5f82b4FA0C04C8a12f68e55C32d50a003f5C0DB","ProtocolVersions":"0xBb419f7f5A5DDb3dfDc9a8Ca8ec4BA5fee52434F","ProtocolVersionsProxy":"0x9F33bbb993d922865a7efe38170b408aB1520771","ProxyAdmin":"0x8551e09B2F363f409A183d16ed873DE66E829474","SafeProxyFactory":"0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2","SystemConfig":"0x2A2D04aA989Da3b988e4db9f1aD021014f793AdB","SystemConfigProxy":"0xb5734dAd91392aA220eaAFB2086999523eB65818"}
    ├─ [0] VM::writeJson(<stringified JSON>, /home/administrator/optimism/packages/contracts-bedrock/deployments/getting-started/.deploy) 
    │   └─ ← ()
    ├─ [0] VM::serializeAddress(<stringified JSON>, SafeSingleton, 0x0000000000000000000000000000000000000000) 
    │   └─ ← {"AddressManager":"0x14D06Eff9fB3f322eeB10FbD4A4f41CE0112A421","L1CrossDomainMessenger":"0x0D264fD80cf0dA2882aC97315DD03f5F640Da230","L1CrossDomainMessengerProxy":"0x6299aF8bC19D31902d6d5c011d73bE42252D146f","L1ERC721Bridge":"0x6E22E0C6787205BdBC043bdaf1A66d43055341Da","L1ERC721BridgeProxy":"0x4fa6415F46B91D8C2E6e2aac660D8c8447aD5b46","L1StandardBridge":"0xe51c06F292E35EB501F1D18bfB5Df381bdd9ffC3","L1StandardBridgeProxy":"0xf3dA0f847332a427a1ce437f9410C9f15ac273DF","L2OutputOracle":"0xB6827f3AFd9D51A6F8307ae9940b4b6209d4E1b5","L2OutputOracleProxy":"0x6F8949A268ad96F56D1dFbD515e6f28dba15C590","OptimismMintableERC20Factory":"0x5c49F95cA0Fb439D663C062029EE56164146e731","OptimismMintableERC20FactoryProxy":"0xA15f8Bc2A424238d4157de19645C86c90fa2F558","OptimismPortal":"0x559a402d0cF60A38Fe9C948182c7CA2BBf30c9e8","OptimismPortalProxy":"0xe5f82b4FA0C04C8a12f68e55C32d50a003f5C0DB","ProtocolVersions":"0xBb419f7f5A5DDb3dfDc9a8Ca8ec4BA5fee52434F","ProtocolVersionsProxy":"0x9F33bbb993d922865a7efe38170b408aB1520771","ProxyAdmin":"0x8551e09B2F363f409A183d16ed873DE66E829474","SafeProxyFactory":"0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2","SafeSingleton":"0x0000000000000000000000000000000000000000","SystemConfig":"0x2A2D04aA989Da3b988e4db9f1aD021014f793AdB","SystemConfigProxy":"0xb5734dAd91392aA220eaAFB2086999523eB65818"}
    ├─ [0] VM::writeJson(<stringified JSON>, /home/administrator/optimism/packages/contracts-bedrock/deployments/getting-started/.deploy) 
    │   └─ ← ()
    ├─ [35453] 0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2::createProxyWithNonce(0x0000000000000000000000000000000000000000, 0xb63e800d000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000deef9f2f5b420c507b86630d75f8deaa1ab00d4f0000000000000000000000000000000000000000000000000000000000000000, 1696005444 [1.696e9]) 
    │   ├─ [330] → new <Unknown>@0xE8D854986B1cCcff56547C5B9bf6B65631B765De
    │   │   └─ ← 0 bytes of code
    │   └─ ← "Create2 call failed"
    └─ ← "Create2 call failed"

== Logs ==
  Connected to network with chainid 11155111
  Storing temp deployment data in /home/administrator/optimism/packages/contracts-bedrock/deployments/getting-started/.deploy
  DeployConfig: reading file /home/administrator/optimism/packages/contracts-bedrock/deploy-config/getting-started.json
  Deploying from Deploy
  Deployment context: getting-started
  Deploying L1 system
  AddressManager deployed at 0x14D06Eff9fB3f322eeB10FbD4A4f41CE0112A421
  ProxyAdmin deployed at 0x8551e09B2F363f409A183d16ed873DE66E829474
  OptimismPortalProxy deployed at 0xe5f82b4FA0C04C8a12f68e55C32d50a003f5C0DB
  L2OutputOracleProxy deployed at 0x6F8949A268ad96F56D1dFbD515e6f28dba15C590
  SystemConfigProxy deployed at 0xb5734dAd91392aA220eaAFB2086999523eB65818
  L1StandardBridgeProxy deployed at 0xf3dA0f847332a427a1ce437f9410C9f15ac273DF
  L1CrossDomainMessengerProxy deployed at 0x6299aF8bC19D31902d6d5c011d73bE42252D146f
  OptimismMintableERC20FactoryProxy deployed at 0xA15f8Bc2A424238d4157de19645C86c90fa2F558
  L1ERC721BridgeProxy deployed at 0x4fa6415F46B91D8C2E6e2aac660D8c8447aD5b46
  ProtocolVersionsProxy deployed at 0x9F33bbb993d922865a7efe38170b408aB1520771
  AddressManager ownership transferred to 0x8551e09B2F363f409A183d16ed873DE66E829474
  OptimismPortal deployed at 0x559a402d0cF60A38Fe9C948182c7CA2BBf30c9e8
  L1CrossDomainMessenger deployed at 0x0D264fD80cf0dA2882aC97315DD03f5F640Da230
  L2OutputOracle deployed at 0xB6827f3AFd9D51A6F8307ae9940b4b6209d4E1b5
  OptimismMintableERC20Factory deployed at 0x5c49F95cA0Fb439D663C062029EE56164146e731
  SystemConfig deployed at 0x2A2D04aA989Da3b988e4db9f1aD021014f793AdB
  L1StandardBridge deployed at 0xe51c06F292E35EB501F1D18bfB5Df381bdd9ffC3
  L1ERC721Bridge deployed at 0x6E22E0C6787205BdBC043bdaf1A66d43055341Da
  ProtocolVersions deployed at 0xBb419f7f5A5DDb3dfDc9a8Ca8ec4BA5fee52434F
Error: 
Create2 call failed

I have also experienced this issue after deploy for the second time

    ├─ [0] VM::serializeAddress(<stringified JSON>, SafeSingleton, 0x0000000000000000000000000000000000000000)
    │   └─ ← {"AddressManager":"0xF46c91764E37dE25Ee12c6d37D6d7df5A158798d","L1CrossDomainMessenger":"0x9350643Ea0983a415377b0B9CB3e51081BaE454a","L1CrossDomainMessengerProxy":"0x385C68257319c4f3071c45090ce18DDDe9D3fEE2","L1ERC721Bridge":"0x35c5F3B114049896e46B2Db7E7cD1860Bb07bD8F","L1ERC721BridgeProxy":"0x1238FCF4b5F56c1402Cfb40D4Dd1C3878F02B06d","L1StandardBridge":"0x22aeAf0BcCf2A6B7C9cBb6ceF77Ac909077A90be","L1StandardBridgeProxy":"0xbA15B55B73b9FB737c25B6a26ce5295f1fF3B377","L2OutputOracle":"0x3feCAAF83785A450219eBe08Bb16bDd6dC16af9b","L2OutputOracleProxy":"0xDEd97E49Ea2edF2768B4eaCD7ef0E4593df1f0dD","OptimismMintableERC20Factory":"0xAa11Af50852fFDA2043cD371e570a57Aa0a88290","OptimismMintableERC20FactoryProxy":"0x89fC2CdB8E44B8790B1FA104f8bc751508f42623","OptimismPortal":"0xD90939e7f5eC8b5571D1e48755Cc27cD22ACd180","OptimismPortalProxy":"0xd89cf090c98D546728F1465B735a12d5bc7bBbe1","ProtocolVersions":"0x31b5900c4dd368c4d1a5559eB74d5813F8AB4cD6","ProtocolVersionsProxy":"0x5B205af5E0C5703E1FDd790d7ea9286AD353C782","ProxyAdmin":"0xd60b1c2916427B52D18653BEd2A0706cdd40d999","SafeProxyFactory":"0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2","SafeSingleton":"0x0000000000000000000000000000000000000000","SystemConfig":"0x53d920a675CA3Bb4Dfa190E4465a662f7b483552","SystemConfigProxy":"0x9dbcfBDb8F4fB1513D2ABBFCcC009d8a423868b8"}
    ├─ [0] VM::writeJson(<stringified JSON>, /root/opstack/optimism/packages/contracts-bedrock/deployments/getting-started/.deploy)
    │   └─ ← ()
    ├─ [35453] 0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2::createProxyWithNonce(0x0000000000000000000000000000000000000000, 0xb63e800d0000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000003757da7a88f415a0cc74d242a162d52a396177e40000000000000000000000000000000000000000000000000000000000000000, 1696014720 [1.696e9])
    │   ├─ [330] → new <Unknown>@0x17A159CcA956f037Fff84117243F8CC5f2d53631
    │   │   └─ ← 0 bytes of code
    │   └─ ← "Create2 call failed"
    └─ ← "Create2 call failed"

== Logs ==
  Connected to network with chainid 5
  Storing temp deployment data in /root/opstack/optimism/packages/contracts-bedrock/deployments/getting-started/.deploy
  DeployConfig: reading file /root/opstack/optimism/packages/contracts-bedrock/deploy-config/getting-started.json
  Deploying from Deploy
  Deployment context: getting-started
  Deploying L1 system
  AddressManager deployed at 0xF46c91764E37dE25Ee12c6d37D6d7df5A158798d
  ProxyAdmin deployed at 0xd60b1c2916427B52D18653BEd2A0706cdd40d999
  OptimismPortalProxy deployed at 0xd89cf090c98D546728F1465B735a12d5bc7bBbe1
  L2OutputOracleProxy deployed at 0xDEd97E49Ea2edF2768B4eaCD7ef0E4593df1f0dD
  SystemConfigProxy deployed at 0x9dbcfBDb8F4fB1513D2ABBFCcC009d8a423868b8
  L1StandardBridgeProxy deployed at 0xbA15B55B73b9FB737c25B6a26ce5295f1fF3B377
  L1CrossDomainMessengerProxy deployed at 0x385C68257319c4f3071c45090ce18DDDe9D3fEE2
  OptimismMintableERC20FactoryProxy deployed at 0x89fC2CdB8E44B8790B1FA104f8bc751508f42623
  L1ERC721BridgeProxy deployed at 0x1238FCF4b5F56c1402Cfb40D4Dd1C3878F02B06d
  ProtocolVersionsProxy deployed at 0x5B205af5E0C5703E1FDd790d7ea9286AD353C782
  AddressManager ownership transferred to 0xd60b1c2916427B52D18653BEd2A0706cdd40d999
  OptimismPortal deployed at 0xD90939e7f5eC8b5571D1e48755Cc27cD22ACd180
  L1CrossDomainMessenger deployed at 0x9350643Ea0983a415377b0B9CB3e51081BaE454a
  L2OutputOracle deployed at 0x3feCAAF83785A450219eBe08Bb16bDd6dC16af9b
  OptimismMintableERC20Factory deployed at 0xAa11Af50852fFDA2043cD371e570a57Aa0a88290
  SystemConfig deployed at 0x53d920a675CA3Bb4Dfa190E4465a662f7b483552
  L1StandardBridge deployed at 0x22aeAf0BcCf2A6B7C9cBb6ceF77Ac909077A90be
  L1ERC721Bridge deployed at 0x35c5F3B114049896e46B2Db7E7cD1860Bb07bD8F
  ProtocolVersions deployed at 0x31b5900c4dd368c4d1a5559eB74d5813F8AB4cD6

To Reproduce

Deploy op stack multiple times using the same admin key

Expected behavior

Deployment successfully

Screenshots

image image

System Specs:

Additional context

User have tried to implement anything in https://github.com/ethereum-optimism/optimism/pull/7449

rowlanja commented 11 months ago

deployments are still broken

thanks173 commented 11 months ago

Created a PR

rowlanja commented 11 months ago

This liked PR does fix the issue