search

ethereum-optimism / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
5.64k stars 3.27k forks source link

Optimize op-e2e: do not repeat tests unaffected by hardforks or connection-type #8022

Open protolambda opened 1 year ago

protolambda commented 1 year ago

Op-e2e has several environment variables that result in some duplication of test runs:

These should be removed: not all op-e2e tests are actually affected by these. Instead, we should parametrize individual test-cases with the settings they need to run with.

ajsutton commented 1 year ago

hmm, we probably should have set OP_E2E_USE_CANYON=false for e2e-http and test-external. They've probably gone back to running the canon tests again which isn't particularly helpful.

Is the idea here to only have one e2e job in CI rather than separate ws and http jobs? If we get there, we could probably remove OP_E2E_CANNON_ENABLED as well.

The external client tests probably should stay since the idea there is to plug in something other than op-geth which makes nearly all the tests useful for compatibility testing (though long term it would be good to have a more dedicated set of reference tests).

ImTei commented 1 year ago

Opened PR for span batch - https://github.com/ethereum-optimism/optimism/pull/8047