ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
167 stars 36 forks source link

integration-tests: End-to-end withdrawals tests #362

Closed mslipper closed 2 years ago

mslipper commented 2 years ago

Includes several fixes to make this work:

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@eac35bb). Click here to learn what that means. The diff coverage is 12.09%.

:exclamation: Current head 92c5c42 differs from pull request most recent head f027e71. Consider uploading reports for the commit f027e71 to get more accurate results

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage        ?   53.48%           
=======================================
  Files           ?       46           
  Lines           ?     4242           
  Branches        ?        0           
=======================================
  Hits            ?     2269           
  Misses          ?     1707           
  Partials        ?      266           
Impacted Files Coverage Δ
l2os/flags/flags.go 100.00% <ø> (ø)
opnode/cmd/main.go 8.45% <0.00%> (ø)
l2os/bindings/l2oo/l2_output_oracle.go 10.38% <10.38%> (ø)
l2os/drivers/l2output/driver.go 63.37% <66.66%> (ø)
opnode/node/server.go 74.13% <100.00%> (ø)
opnode/rollup/derive/payload_attributes.go 76.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eac35bb...f027e71. Read the comment docs.

mslipper commented 2 years ago

Hmm.. the contract creation is OOG here, but not locally. Will look deeper over the weekend.

trianglesphere commented 2 years ago

Hmm.. the contract creation is OOG here, but not locally. Will look deeper over the weekend.

Did you figure this out?

mslipper commented 2 years ago

Hmm.. the contract creation is OOG here, but not locally. Will look deeper over the weekend.

Did you figure this out?

I did, yes. It's fixed now.

trianglesphere commented 2 years ago

Hmm.. the contract creation is OOG here, but not locally. Will look deeper over the weekend.

Did you figure this out?

I did, yes. It's fixed now.

What was the fix?

mslipper commented 2 years ago

Fixed @trianglesphere's comments.