search

ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
168 stars 36 forks source link

style: add comments and cleanup to state.go #371

Closed smartcontracts closed 2 years ago

smartcontracts commented 2 years ago

Description Second comment+cleanup PR for state.go. Adds lots of comments and shifts a few things around to make the code easier to read. Also fixes one bug found in state.go.

codecov-commenter commented 2 years ago

Codecov Report

Merging #371 (92fb04f) into main (c69fffd) will increase coverage by 0.01%. The diff coverage is 74.07%.

:exclamation: Current head 92fb04f differs from pull request most recent head 04c6ef1. Consider uploading reports for the commit 04c6ef1 to get more accurate results

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   40.78%   40.80%   +0.01%     
==========================================
  Files          46       46              
  Lines        5791     5799       +8     
==========================================
+ Hits         2362     2366       +4     
- Misses       3145     3149       +4     
  Partials      284      284
Impacted Files Coverage Δ
opnode/rollup/driver/state.go 77.23% <74.07%> (-0.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c69fffd...04c6ef1. Read the comment docs.

norswap commented 2 years ago

@smartcontracts I'm interested in reviewing this when it's ready for review!

trianglesphere commented 2 years ago

@smartcontracts closing b/c this never got pulled out of draft status. LMK if you want to reopen it in the monorepo