Closed trianglesphere closed 2 years ago
trianglesphere
commented
2 years ago Issue found: the off by one is in the contract (at least given how we setup the system). The issue was that I was building the wrong set of contracts (& also had to fix a lot of things to make the contract building work).
codecov-commenter
commented
2 years ago Merging #390 (1a19fcf) into main (f550870) will decrease coverage by
0.02%. The diff coverage is40.00%.
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 49.86% 49.83% -0.03%
==========================================
Files 51 51
Lines 5102 5117 +15
==========================================
+ Hits 2544 2550 +6
- Misses 2232 2239 +7
- Partials 326 328 +2 | Impacted Files | Coverage Δ | |
|---|---|---|
| l2os/bindings/l2oo/l2_output_oracle.go | 8.88% <ø> (ø) |
|
| opnode/contracts/deposit/deposit_feed_raw.go | 3.90% <ø> (ø) |
|
| opnode/contracts/l1block/l1_block_info_raw.go | 25.95% <ø> (ø) |
|
| l2os/drivers/l2output/driver.go | 60.43% <10.00%> (-2.94%) |
:arrow_down: |
| opnode/rollup/driver/step.go | 62.87% <100.00%> (+0.50%) |
:arrow_up: |
| opnode/test/setup.go | 71.82% <100.00%> (+0.08%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update f550870...1a19fcf. Read the comment docs.
trianglesphere
commented
2 years ago Closing in favor of a new branch
Description A clear and concise description of the features you're adding in this pull request.
Additional context Add any other context about the problem you're solving.
Metadata