ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
168 stars 36 forks source link

New Deposit Event #412

Closed trianglesphere closed 2 years ago

trianglesphere commented 2 years ago

Description This is the contracts and rollup node work to support the new fields for deposit gas metering. This adds the new fields to the contracts and uses a new version of L2 geth that has the fields in the deposit transaction (but has not implemented the new metering).

Testing

Fuzzed FuzzUnmarshallLogEvent for about 3 hours locally without any founds bugs. It's running around 8,000/sec and found ~200 interesting cases.

Metadata

codecov-commenter commented 2 years ago

Codecov Report

Merging #412 (7d4a83f) into main (3a1f6ff) will decrease coverage by 0.01%. The diff coverage is 65.51%.

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   51.68%   51.67%   -0.02%     
==========================================
  Files          57       57              
  Lines        5764     5775      +11     
==========================================
+ Hits         2979     2984       +5     
- Misses       2415     2419       +4     
- Partials      370      372       +2     
Impacted Files Coverage Δ
opnode/contracts/deposit/deposit_feed_raw.go 5.21% <33.33%> (ø)
opnode/rollup/derive/payload_attributes.go 75.80% <73.91%> (-0.15%) :arrow_down:
l2os/service.go 90.78% <0.00%> (-3.95%) :arrow_down:
opnode/node/api.go 58.64% <0.00%> (-0.76%) :arrow_down:
bss/sequencer/driver.go 75.00% <0.00%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a1f6ff...7d4a83f. Read the comment docs.

trianglesphere commented 2 years ago

Closing because we have moved away from the additional gas mechanism for the deposit fee version.