ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
167 stars 35 forks source link

opnode: Withdrawal E2E test in go #423

Closed trianglesphere closed 2 years ago

trianglesphere commented 2 years ago

Description

This does the following:

Metadata

tynes commented 2 years ago

Some of this stuff is going to change pending https://github.com/ethereum-optimism/optimistic-specs/pull/421 due to it being updated to support backwards compatible withdrawals

codecov-commenter commented 2 years ago

Codecov Report

Merging #423 (20143e9) into main (fb044a6) will decrease coverage by 1.35%. The diff coverage is 28.65%.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   51.88%   50.53%   -1.36%     
==========================================
  Files          63       66       +3     
  Lines        6703     7215     +512     
==========================================
+ Hits         3478     3646     +168     
- Misses       2784     3094     +310     
- Partials      441      475      +34     
Impacted Files Coverage Δ
opnode/contracts/withdrawer/withdrawer_raw.go 4.18% <4.18%> (ø)
opnode/withdrawals/utils.go 59.23% <59.23%> (ø)
opnode/withdrawals/proof.go 59.70% <59.70%> (ø)
opnode/test/geth.go 65.07% <100.00%> (+0.27%) :arrow_up:
opnode/test/setup.go 72.81% <100.00%> (ø)
l2os/txmgr/txmgr.go 95.65% <0.00%> (+1.86%) :arrow_up:
opnode/contracts/deposit/deposit_feed_raw.go 11.40% <0.00%> (+6.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb044a6...20143e9. Read the comment docs.

tynes commented 2 years ago

This could use a rebase

trianglesphere commented 2 years ago

This could use a rebase

Will do once #416 is merged