search

ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
168 stars 36 forks source link

specs: deposits pay gas on L1 #436

Closed tynes closed 2 years ago

tynes commented 2 years ago

Description I didn't notice anywhere in the specs where it is clearly mentioned that deposits are not charged for gas on L2. Correct me if I am wrong, but we are not going with the additional gas scheme so now the only way that deposits are metered is based on the L1 eip1159 curve in the deposit contract

codecov-commenter commented 2 years ago

Codecov Report

Merging #436 (fdd552c) into main (92fccc2) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   51.50%   51.54%   +0.03%     
==========================================
  Files          70       70              
  Lines        7582     7582              
==========================================
+ Hits         3905     3908       +3     
+ Misses       3154     3152       -2     
+ Partials      523      522       -1
Impacted Files Coverage Δ
l2os/txmgr/txmgr.go 95.65% <0.00%> (+1.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92fccc2...fdd552c. Read the comment docs.

trianglesphere commented 2 years ago

The addition to the spec is correct. There is also a very similar addition in https://github.com/ethereum-optimism/optimistic-specs/pull/401

trianglesphere commented 2 years ago

Closing in favor of #401