search

ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
167 stars 35 forks source link

contracts: Fix Low and Informational OZ audit findings #455

Closed maurelian closed 2 years ago

maurelian commented 2 years ago

This PR fixes the Low and Informational severity issues issues in the OpenZeppelin audit (which is not yet public). Each commit in this PR clearly references the finding that it addresses.

In order to review, I suggest comparing between the audit report (see the Open Zeppelin Audit Resolution doc in Notion), and the commit which mentions it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #455 (a70faaf) into main (ebb8c2c) will decrease coverage by 0.08%. The diff coverage is n/a.

:exclamation: Current head a70faaf differs from pull request most recent head ad4ab14. Consider uploading reports for the commit ad4ab14 to get more accurate results

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   52.27%   52.18%   -0.09%     
==========================================
  Files          70       70              
  Lines        7855     7855              
==========================================
- Hits         4106     4099       -7     
- Misses       3197     3202       +5     
- Partials      552      554       +2
Flag Coverage Δ
unittests 52.18% <ø> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-bindings/deposit/deposit_feed_raw.go 11.40% <ø> (ø)
op-bindings/l1block/l1_block_info_raw.go 28.27% <ø> (ø)
op-bindings/l2oo/l2_output_oracle.go 8.60% <ø> (ø)
op-bindings/withdrawer/withdrawer_raw.go 4.18% <ø> (ø)
op-e2e/setup.go 72.88% <ø> (ø)
op-node/withdrawals/utils.go 59.23% <ø> (ø)
op-proposer/drivers/l2output/driver.go 65.19% <ø> (ø)
op-node/p2p/discovery.go 67.76% <0.00%> (-2.57%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b2990e...ad4ab14. Read the comment docs.