Use @eth-optimism/dev package

smartcontracts commented 3 years ago

@eth-optimism/dev is a simple npm package that automatically imports many of the common packages we use when developing our various TypeScript modules. It allows us to remove some dependencies and standardizes the way we configure certain things. I'd like to add that package to this module.

Here's a step-by-step of how to do this:

Install @eth-optimism/dev. We'll put this in our dev dependencies.
```
yarn add @eth-optimism/dev --dev
```

Remove (newly) unnecessary packages:

yarn remove @types/chai @types/chai-as-promised @types/mocha @types/node ts-node tslint tslint-config-prettier tslint-no-focused-test tslint-plugin-prettier typescript

Update tslint.json to use extend the shared tslint.json config file.
```
{
"extends": "@eth-optimism/dev/tslint.json"
}
```

That should be it! Make sure to run yarn lint before making a pull request :-)

MichaelMacaulay commented 3 years ago

I'd like to claim this issue.

gakonst commented 3 years ago

Hey @MichaelMacaulay I think there might be some confusion here regarding your PR: The eth-optimism/dev package is good as-is, what @smartcontracts meant is that you should open a PR in this repository, removing these deps!

smartcontracts commented 3 years ago

Whoops, sorry for any confusion. @gakonst is correct. @MichaelMacaulay Are you still interested in tackling this?

ethereum-optimism / smock

Use @eth-optimism/dev package #18