search

ethereum-optimism / solidity

[Optimism] (Slightly) modified Solidity compiler
GNU General Public License v3.0
38 stars 15 forks source link

Fix deployedBytecode to perform Find and replace #21

Open K-Ho opened 3 years ago

ben-chain commented 3 years ago

basically we need to either:

  1. replicate this logic for deployedbytecode, but get it to work
  2. upgrade to a version of solidity where we don't have to do the hack in the first place, so that the kall builtin actually can be accepted as a literal value. This PR is gonna do the trick, but it might come with it an entire compiler rewrite using yul IR!
K-Ho commented 3 years ago

Bump on this - this becomes an issue for anyone who wishes to use deployedBytecode to verify and publish on etherscan (cc @ajsantander)

Enigmatic331 commented 3 years ago

Will be keeping an eye on this 😄 - I guess the issue is mostly present in 0.5.16 as I had luck with 0.7.6.

Haven't tried 0.6.12 and 0.8.4 yet (maybe I should)