search

ethereum-optimism / superchain-ops

36 stars 32 forks source link

tasks(eth/base): add Base Mainnet MCP L1 playbook #241

Closed sbvegan closed 3 months ago

sbvegan commented 3 months ago

This PR adds the Base Mainnet MCP L1 upgrade task.

Review instructions:

  1. Follow this folder's instructions to execute playbook and make sure it does not revert
  2. Verify:
    1. That the Validations file is exactly what you see on Tenderly
    2. That the Validations file is consistent with what we'd expect via our notion analysis
    3. That the hardcoded values in ./tasks/eth/base-001-MCP-L1/SignFromJson.s.sol are all accurate and sensible
  3. Diff the new tasks/eth/metal-001-MCP-L1/SignFromJson.s.sol against the existing tasks/eth/zora-001-MCP-L1/SignFromJson.s.sol to better see the changes, since most of the file is a copy/paste of that.
blmalone commented 3 months ago

I'm getting different Data to sign: when I simulate with council vs foundation

blaine@blaines-MacBook-Pro base-001-MCP-L1 % SIMULATE_WITHOUT_LEDGER=1 just \
   --dotenv-path $(pwd)/.env \
   --justfile ../../../nested.just \                                                                                                    
   simulate \
   foundation | grep -A 1 'vvvvvvvv' | tail -n 1 | tr -d '[:space:]'  
0x19014e6a6554de0308f5ece8ff736beed8a1b876d16f5c27cac8e466d7de0c703890ccea5b698be07a213a718057732f8610272193e308a40deea18726fd867f15ff%                   

blaine@blaines-MacBook-Pro base-001-MCP-L1 % SIMULATE_WITHOUT_LEDGER=1 just \ 
   --dotenv-path $(pwd)/.env \
   --justfile ../../../nested.just \
   simulate \
   council | grep -A 1 'vvvvvvvv' | tail -n 1 | tr -d '[:space:]'
0x190188aac3dc27cc1618ec43a87b3df21482acd24d172027ba3fbb5a5e625d895a0bdb6f2fd041c9e187360efa7728b40ea766e4abc973b9de1b33306726a41fcc1a

My understanding is that these should match.

Update: This is okay and expected behavior.

maurelian commented 3 months ago

Added two commits that fixed the conflict in the CI config and make the ordering match how we've been discussing these ceremonies.

https://github.com/ethereum-optimism/superchain-ops/pull/241/files/dea6987fcca1679f6a88f7a0f500ac77d7118245..1c0659f166a4b33e04875853e59cbd4f95f20f3f