ethereum-optimism / superchain-registry

An index of chains which serves as the source of truth for who’s in the Superchain Ecosystem
MIT License
79 stars 92 forks source link

SuperchainRegistry: increase validation coverage of standard config `parameters` to 100% #293

Closed geoknee closed 4 months ago

geoknee commented 6 months ago

~This relies on the full config (defined here in the specs https://specs.optimism.io/protocol/configurability.html?highlight=standard#op-stack-configurability) being added to standard-config-mainnet.toml (and similar files for testnets and frontier chains).~

The strategy will be to add each config parameter and a validation check that covers it, proceeding line by line until all parameters are in place and covered.

Each parameter should be subject to a validation check.

Validation checks written for {Standard/Frontier} x {Mainnet, Testnet} chains, with minimal chain-specific exceptions . Covers all parameters in the standard config and copes with all supported contract versions and hardforks.

This may be easier to tackle if we do ethereum-optimism/superchain-registry#294 first, or else we can do a refactor after it is all done to tidy things up. (Where possible, testing code should be deduplicated and refactored for maximum legibility. )

Edit: this ticket only covers "consensus parameters" and "policy parameters" from this doc https://www.notion.so/oplabs/OP-Stack-Configurability-from-a-SuperchainRegistry-validation-POV-9c335a936007456b89777f5a84fba58d

The remaining checks are covered by this ticket ethereum-optimism/client-pod#913

geoknee commented 6 months ago

This document breaks down the config line by line, and shows which are covered by a check or don't even need a validation check: https://www.notion.so/oplabs/OP-Stack-Configurability-from-a-SuperchainRegistry-validation-POV-9c335a936007456b89777f5a84fba58d

BlocksOnAChain commented 5 months ago

added to the tracking view for registry.