search

ethereum-optimism / superchain-registry

An index of chains which serves as the source of truth for who’s in the Superchain Ecosystem
MIT License
72 stars 71 forks source link

Support ResourceMetering contract in CheckSecurityConfigs #37

Closed zchn closed 2 months ago

zchn commented 9 months ago

Is your feature request related to a problem? Please describe. The CheckSecurityConfigs implemented in https://github.com/ethereum-optimism/superchain-registry/pull/31/files lacks support for ResourceMetering.

Describe the solution you'd like We should figure out what security properties we need to check for ResourceMetering contract, and add these checks to CheckSecurityConfigs

Describe alternatives you've considered None. But happy to discuss alternatives if anybody has anything in mind.

Additional context From a discussion at https://github.com/ethereum-optimism/superchain-registry/pull/31/files#r1417591316

geoknee commented 3 months ago

@zchn we now have checks on the resource_config: https://github.com/ethereum-optimism/superchain-registry/blob/8b3942df1e1cad7335ef9b78820d6fe22191a55b/validation/standard/standard-config-mainnet.toml#L1-L8

(Although these were removed from the standard config spec recently)

Does that cover what you had in mind here? Can we close this issue?