Validation: wrap local chain info maps with mutexes - Githubissues

ethereum-optimism / superchain-registry

An index of chains which serves as the source of truth for who’s in the Superchain Ecosystem

MIT License

84 stars 99 forks source link

Validation: wrap local chain info maps with mutexes #669

Closed vdamle closed 2 weeks ago

vdamle commented 2 weeks ago

Appears that there's a race when attempting to update local chain ID/Name maps from multiple tests which are kicked off concurrently.
Also refactored the code a bit to wrap the global vars into a struct

Checklist

[ ] ~I have declared the chain at the appropriate Superchain Level.~
[x] I have run just validate <chain-id> locally to ensure all local validation checks pass.
[x] I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

ref: https://github.com/ethereum-optimism/superchain-registry/issues/668

vdamle commented 2 weeks ago

Did you consider using https://pkg.go.dev/sync#Map ?

Thanks for the suggestion, agree that's much simpler to use for this case and modified code accordingly.