💅 refactor L2NativeSuperchainERC20 and SuperchainWETH logging

ethereum-optimism / supersim

Local Multi-L2 Development Environment

MIT License

144 stars 57 forks source link

💅 refactor L2NativeSuperchainERC20 and SuperchainWETH logging #253

Closed tabshaikh closed 2 weeks ago

tabshaikh commented 2 weeks ago

Description

updated L2NativeSuperchainERC20 and SuperchainWETH to use similar logging

Metadata

https://github.com/ethereum-optimism/supersim/issues/144

tabshaikh commented 2 weeks ago

@jakim929 pushed changes using SuperchainERC20. Was previously abstracting a lot because thought there were no common interface but as they both use ICrosschainERC20 things are much cleaner

jakim929 commented 2 weeks ago

@tabshaikh thanks this looks great! good to go once CI passes

tabshaikh commented 2 weeks ago

@jakim929 weirdly the admin test was failing, which was also failing in the main branch. fixed that