search

ethereum-pocr / go-ethereum

GNU Lesser General Public License v3.0
1 stars 0 forks source link

Migration to Ploitari v1.10.17 #10

Closed guenoledc closed 2 years ago

guenoledc commented 2 years ago

In GitLab by @sjehanfinaxys on Mar 30, 2022, 08:56

Merge geth with the new updates

guenoledc commented 2 years ago

In GitLab by @sjehanfinaxys on Apr 8, 2022, 10:21

@guenoledc Starting this. Are we considering all features ?

Example: This release also adds a new tool to convert 'legacy' receipts into a newer format. During startup, geth will check the database and tell you if you need to perform the conversion. Converting receipts is only needed if geth's ancients database has not been resynced from scratch during the last couple of years. It is recommended to back-up your receipts freezer table (ancients/receipts*) before performing the conversion.

We need to maintain geth POW consensus as well for older databases (more than a few years). I can merge all by default, bute since merging become manual, we could adopt a strategy to merge only clique engine and the remaining backend

guenoledc commented 2 years ago

Hum ... Thanks @sjehanfinaxys for this review

If we need to merge our final geth version n the official repo one day, then we need to facilitate the merge to the dev community. So I would say we need to keep all the existing Ploitari code.

But this can possibly be done a bit later in the project as it has no value for us now.

You say the merge is manual. Is there some merge conflicts with your code ?

guenoledc commented 2 years ago

In GitLab by @sjehanfinaxys on Apr 22, 2022, 11:37

Hi @guenole. With @khaledFynaxis we defined a way to merge from a tag version of the latest go-ethereum public release and create a PR out of it, to regularly assess their change.

Will document all this in the devops repo, MR through gitlab merge tools and close.