ethereum / EIP-Bot

A collection of bots that make life easier on editors
Creative Commons Zero v1.0 Universal
41 stars 37 forks source link

Close some issues #104

Closed Pandapip1 closed 2 years ago

Pandapip1 commented 2 years ago

Specifically, the linting issues.

Those are being handled by https://github.com/ethereum/eipw

Pandapip1 commented 2 years ago

Issues to be closed: https://github.com/ethereum/EIP-Bot/issues/98 https://github.com/ethereum/EIP-Bot/issues/96 https://github.com/ethereum/EIP-Bot/issues/93 https://github.com/ethereum/EIP-Bot/issues/74 https://github.com/ethereum/EIP-Bot/issues/73 https://github.com/ethereum/EIP-Bot/issues/72 https://github.com/ethereum/EIP-Bot/issues/71 https://github.com/ethereum/EIP-Bot/issues/70 https://github.com/ethereum/EIP-Bot/issues/69 https://github.com/ethereum/EIP-Bot/issues/68 PRs to be closed: https://github.com/ethereum/EIP-Bot/pull/89 https://github.com/ethereum/EIP-Bot/pull/87

Pandapip1 commented 2 years ago

CC @MicahZoltu

MicahZoltu commented 2 years ago

It is probably better to comment on each of the respective issues, rather than collating them here. It makes it harder to track/manage and discuss when there is a monolithic list like this.

Are you sure EIPW handles #93? I thought we still had a problem with that?

MicahZoltu commented 2 years ago

Same question for #74 and #69, are we sure the bot handles these? For #69 I thought we were still actively debating what the behavior should be and the bot doesn't do anything about them at the moment?

Pandapip1 commented 2 years ago

Are you sure EIPW handles https://github.com/ethereum/EIP-Bot/issues/93? I thought we still had a problem with that?

Same question for https://github.com/ethereum/EIP-Bot/issues/74 and https://github.com/ethereum/EIP-Bot/issues/69, are we sure the bot handles these?

There are open issues on the eipw repo. This place is no longer the right place to track this.

MicahZoltu commented 2 years ago

I don't see a replication of #93 on EIPW issues list, do you happen to know which number it is?

I guess #74 is handled by the more general "no external links allowed" lint that we currently have.

I also don't see an issue duplicating #69 in the EIPW repository.

Pandapip1 commented 2 years ago

Issues made.