search

ethereum / EIP-Bot

A collection of bots that make life easier on editors
Creative Commons Zero v1.0 Universal
41 stars 37 forks source link

Download and render external links as PDFs #75

Closed SamWilsn closed 2 years ago

SamWilsn commented 2 years ago

This issue should probably be split into many issues with different priorities.

I disagree. Making PDFs of web pages might still be useful.

I suggest the following:

  1. All external links are converted to PDFs.
  2. All the PDFs are put in a new folder, assets/references.
  3. The links are changed to IPFS multihashes.
  4. The Ethereum foundation runs an IPFS node that pins these files.

I'll make this a new issue in the EIP repository.

Originally posted by @Pandapip1 in https://github.com/ethereum/EIP-Bot/issues/55#issuecomment-1103834429

SamWilsn commented 2 years ago

I am against mirroring pages automatically as PDFs in the EIPs repository. It's super complex, opens up a ton of possible attack vectors, and will take a ton of space. Not to mention that git doesn't handle binaries super well, and the crazy copyright considerations.

I would not be against a tool to mirror a webpage in a compatible way that an author could use to include an external reference. I just don't think it should be automatic.

JEAlfonsoP commented 2 years ago

I would suggest to discuss this issue during the next call..

Pandapip1 commented 2 years ago

Since we're not allowing external links, I think we can close this.