search

ethereum / EIP-Bot

A collection of bots that make life easier on editors
Creative Commons Zero v1.0 Universal
41 stars 37 forks source link

EIP Bot should not require changes to the EIP file to modify EIP asset files #95

Open Pandapip1 opened 2 years ago

Pandapip1 commented 2 years ago

See https://github.com/ethereum/EIPs/pull/5213

Example error:

file assets/eip-4907/contracts/ERC4907.sol is associated with EIP 4907 but there are no changes being made to corresponding EIP itself. To assure that the change is authorized by the relevant stake-holders, you must also make changes to the EIP file itself for the asset changes to be eligible for auto-merge

JEAlfonsoP commented 2 years ago

Question: is there a determined list for "normal rules for changing files in assets directory" ?

Pandapip1 commented 2 years ago

is there a determined list for "normal rules for changing files in assets directory" ?

No, except for "the EIP has to be modified too."

JEAlfonsoP commented 2 years ago

To make this clear:

If any EIP-asset file is modified the EIP-Bot fails and requests authors to modify EIP-File itself ?

Is there some one else working on it ?

Pandapip1 commented 2 years ago

No, nobody else it working on it. Go ahead!

JEAlfonsoP commented 2 years ago

Roger that, I will take a look on it..

SamWilsn commented 2 years ago

Nope, I'm not working on this.