ethereum / EIP-Bot

A collection of bots that make life easier on editors

Creative Commons Zero v1.0 Universal

41 stars 37 forks source link

EIP Bot should error if a file contains an SPDX identifier other than CC0 #96

Closed Pandapip1 closed 2 years ago

Pandapip1 commented 2 years ago

This would help avoid things like https://github.com/ethereum/EIPs/blob/master/assets/eip-4400/contracts/ERC721Consumable.sol having the wrong license.

JEAlfonsoP commented 2 years ago

Please could you check PR 87. I think that resolves this issue either.

MicahZoltu commented 2 years ago

87

MicahZoltu commented 2 years ago

Addressed by EIPW now.

SamWilsn commented 2 years ago

It isn't (see ethereum/eipw#11), and only checking the EIP itself is on the roadmap. I don't have any plans to scan Solidity files (or package.json, or any other package manager's files.)

Pandapip1 commented 2 years ago

I don't have any plans to scan Solidity files (or package.json, or anything other package manager's files.)

Uh, why not? It goes way better in the validator than it does here.

SamWilsn commented 2 years ago

Uh, why not?

I feel like scanning projects for licenses is incredibly hard, and I'd rather not create a lint that gives an over-exaggerated sense of safety.

Pandapip1 commented 2 years ago

I can write those lints if you want. I'd have to learn rust first, but it can't be too hard... right?

SamWilsn commented 2 years ago

Rust is fun! Totally open to a PR, but keep my concern in mind.

Pandapip1 commented 2 years ago

Did one better: https://github.com/ethereum/EIPs/pull/5379. Now you can continue to only care about EIPs and let other actions do the other work :)

MicahZoltu commented 2 years ago

Re-opening this until this gets implemented somewhere, or an issue to track the problem is created somewhere.

Pandapip1 commented 2 years ago

Tracked in https://github.com/ethereum/EIPs/pull/5379