ethereum / EIPs

The Ethereum Improvement Proposal repository
https://eips.ethereum.org/
Creative Commons Zero v1.0 Universal
12.9k stars 5.29k forks source link

Links from EIPs to ERCs cause `eipw` to fail #8689

Open SamWilsn opened 4 months ago

SamWilsn commented 4 months ago

Pull Request

https://github.com/ethereum/EIPs/pull/8594/files

What happened?

When you link from an EIP to an ERC using the correct syntax, the markdown-link-status lint errors out. This is incorrect.

Relevant log output

2024-06-17T02:18:49.9597214Z ##[error]error[markdown-link-status]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-link-status/
2024-06-17T02:18:49.9625536Z ##[error]error[markdown-refs]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/
2024-06-17T02:18:49.9634594Z ##[error]validation found errors :(
github-actions[bot] commented 2 months ago

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Mortiemi commented 2 months ago

Żądanie ściągnięcia

https://github.com/ethereum/EIPs/pull/8594/files

Co się stało?

When you link from an EIP to an ERC using the correct syntax, the markdown-link-status lint errors out. This is incorrect.

Odpowiednie wyjście dziennika

2024-06-17T02:18:49.9597214Z ##[error]error[markdown-link-status]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-link-status/
2024-06-17T02:18:49.9625536Z ##[error]error[markdown-refs]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/
2024-06-17T02:18:49.9634594Z ##[error]validation found errors :(
GIgako19929 commented 1 month ago

https://github.com/ethereum/EIPs/issues/8689~~```

rutefig commented 1 month ago

Hey @SamWilsn can I have this one pls?