search

ethereum / ERCs

The Ethereum Request for Comment repository
Creative Commons Zero v1.0 Universal
302 stars 407 forks source link

Add ERC: Common Quote Oracle #500

Closed alcueca closed 2 weeks ago

alcueca commented 2 months ago

For a while now a bunch of us have been toiling on what is now a minimal standard for oracle value feeds. This all probably started when I wrote this article about using value conversions instead of prices in smart contracts:

In very short, this is a minimal standard with a single function to get the value of an amount of an asset in terms of another asset. There are a number of adapters for current oracles from the community and from Euler.

eip-review-bot commented 2 months ago

✅ All reviewers have approved.

alcueca commented 2 months ago

Oh great, now it seems to be stuck. Could I get some help here?

github-actions[bot] commented 2 months ago

The commit b56fd9a4155b151ea19a06e5ba5021ac1251836b (as a parent of 1c856247bcfbb464a2a03b4d241592a2e0a2988a) contains errors. Please inspect the Run Summary for details.

alcueca commented 2 months ago

Alright, CI passes, could we please get this merged into draft, @axic, @g11tech, @SamWilsn, @xinbenlv?

alcueca commented 2 months ago

Also, maybe make this a bit more prominent or fix it. This was quite an adventure.

image

https://github.com/ethereum/ERCs/issues/8

alcueca commented 2 months ago

If there aren't any more comments, could we please get this merged, please?

@axic, @g11tech, @SamWilsn, @xinbenlv

alcueca commented 1 month ago

Henloooooo, could we please get this merged?

@axic, @g11tech, @SamWilsn, @xinbenlv

alcueca commented 1 month ago

@abcoathup, is there anything that we can do to please move this along?

abcoathup commented 1 month ago

@abcoathup, is there anything that we can do to please move this along?

@alcueca you need an ERC editor to review. (Which I am not)

You could try attending EIP office hours. https://github.com/ethcatherders/EIPIP/issues/342

alcueca commented 1 month ago

@abcoathup, do you have any idea how to debug that jekyll job that is failing? There is not much between the commit that was working, and the commit where it started not to work.