Closed alcueca closed 2 weeks ago
✅ All reviewers have approved.
Oh great, now it seems to be stuck. Could I get some help here?
The commit b56fd9a4155b151ea19a06e5ba5021ac1251836b (as a parent of 1c856247bcfbb464a2a03b4d241592a2e0a2988a) contains errors. Please inspect the Run Summary for details.
Alright, CI passes, could we please get this merged into draft, @axic, @g11tech, @SamWilsn, @xinbenlv?
Also, maybe make this a bit more prominent or fix it. This was quite an adventure.
If there aren't any more comments, could we please get this merged, please?
@axic, @g11tech, @SamWilsn, @xinbenlv
Henloooooo, could we please get this merged?
@axic, @g11tech, @SamWilsn, @xinbenlv
@abcoathup, is there anything that we can do to please move this along?
@abcoathup, is there anything that we can do to please move this along?
@alcueca you need an ERC editor to review. (Which I am not)
You could try attending EIP office hours. https://github.com/ethcatherders/EIPIP/issues/342
@abcoathup, do you have any idea how to debug that jekyll job that is failing? There is not much between the commit that was working, and the commit where it started not to work.
For a while now a bunch of us have been toiling on what is now a minimal standard for oracle value feeds. This all probably started when I wrote this article about using value conversions instead of prices in smart contracts:
In very short, this is a minimal standard with a single function to get the value of an amount of an asset in terms of another asset. There are a number of adapters for current oracles from the community and from Euler.