Update ERC-7578: Move to Review

ethereum / ERCs

The Ethereum Request for Comment repository

Creative Commons Zero v1.0 Universal

302 stars 407 forks source link

Closed V1d0r closed 1 month ago

V1d0r commented 2 months ago

Move to Review

eip-review-bot commented 2 months ago

✅ All reviewers have approved.

gabrielstoica commented 2 months ago

Hey @SamWilsn!

Thanks for your feedback - it was very valuable and we've tried to cover all points as follows:

Moved all definitions to the specification section;
Updated the rationale to be less restrictive and define the externally visible behaviour;
Removed the setProperties definition to improve the standard's interoperability;

Edit: We've also addressed your point from the Ethereum Magicians forum here.

Let me know what you think!