search

ethereum / ERCs

The Ethereum Request for Comment repository
Creative Commons Zero v1.0 Universal
302 stars 407 forks source link

Update ERC-7656: Update naming for clarity #502

Closed sullof closed 2 months ago

sullof commented 2 months ago

After conversations with members of the community, it was clear that the name IERC7656Linked was better than IERC7656Contract but still not ideal. Then, the decision to change it to IERC7656Service, which better aligns with the goal of the ERC, i.e., allowing NFT to own services that extend the capability of the single NFT.

eip-review-bot commented 2 months ago

✅ All reviewers have approved.

github-actions[bot] commented 2 months ago

The commit 92d38e96b3a488cb067e3868a42c3c2a9ff5b88d (as a parent of 9ad71a4254908216e5b2991dde11100f81b1a648) contains errors. Please inspect the Run Summary for details.

sullof commented 2 months ago

@abcoathup I am having bot errors that are unrelated to the PR's proposed changes. Do you know which is the best practice in these cases?

abcoathup commented 2 months ago

@abcoathup I am having bot errors that are unrelated to the PR's proposed changes. Do you know which is the best practice in these cases?

@sullof I assume you resolved them.
For unrelated review-bot issues I suggest reporting in the EIP-editors channel of EthCatHerders Discord.

sullof commented 2 months ago

@abcoathup I made another push but obtained the same error. Then, at some moment, the issue got fixed by itself. I have no idea why. Anyway, thanks, I will ask in the Discord server