Closed dongri closed 1 week ago
ERCS/erc-3009.md
Requires 1 more reviewers from @davidlknott, @kbrizzle, @petejkim
Isn't anyone going to review it?
The commit 4f950c2fabac1485f3367fd470beeb4c5b1598dd (as a parent of 302c0c55cbbb03eb3037d292513cac8c67e7f3c5) contains errors. Please inspect the Run Summary for details.
I can approve this as an Editor, but you'll need to wait for one of the proposal authors to approve the pull request before it is merged.
Alternatively, if you'd like to champion this proposal, you can copy the text into a new proposal (adding yourself as an author) pull request.
@SamWilsn Thank you for your review. When submitting a pull request with a new proposal, do I need to change the EIP number? Should it be +1 from the latest EIP?
@dongri to create a new ERC please create the PR in the ERC repo. An ERC number will be manually assigned by an editor/associate.
@abcoathup Thanks! https://github.com/ethereum/ERCs/pull/598
There is an error in signature verification with the current sample code.
It is necessary to change the order of
bytes32(chainId)
andaddress(this)
to comply withkeccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)")
.