search

ethereum / ERCs

The Ethereum Request for Comment repository
Creative Commons Zero v1.0 Universal
302 stars 407 forks source link

Update ERC-3009: Move to Draft #504

Closed dongri closed 1 week ago

dongri commented 2 months ago

There is an error in signature verification with the current sample code.

EIP3009: invalid signature

It is necessary to change the order of bytes32(chainId) and address(this) to comply with keccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)").

eip-review-bot commented 2 months ago

File ERCS/erc-3009.md

Requires 1 more reviewers from @davidlknott, @kbrizzle, @petejkim

dongri commented 2 months ago

Isn't anyone going to review it?

github-actions[bot] commented 2 weeks ago

The commit 4f950c2fabac1485f3367fd470beeb4c5b1598dd (as a parent of 302c0c55cbbb03eb3037d292513cac8c67e7f3c5) contains errors. Please inspect the Run Summary for details.

dongri commented 2 weeks ago

I can approve this as an Editor, but you'll need to wait for one of the proposal authors to approve the pull request before it is merged.

Alternatively, if you'd like to champion this proposal, you can copy the text into a new proposal (adding yourself as an author) pull request.

@SamWilsn Thank you for your review. When submitting a pull request with a new proposal, do I need to change the EIP number? Should it be +1 from the latest EIP?

dongri commented 2 weeks ago

@SamWilsn https://github.com/ethereum/EIPs/pull/8819

abcoathup commented 2 weeks ago

@dongri to create a new ERC please create the PR in the ERC repo. An ERC number will be manually assigned by an editor/associate.

dongri commented 2 weeks ago

@abcoathup Thanks! https://github.com/ethereum/ERCs/pull/598