search

ethereum / ERCs

The Ethereum Request for Comment repository
Creative Commons Zero v1.0 Universal
302 stars 407 forks source link

Add ERC: Structured Data Clear Signing Format #509

Open lcastillo-ledger opened 2 months ago

lcastillo-ledger commented 2 months ago

This is Ledger's proposal for a format enabling smartcontract developers to define the intended UI on wallets when signing a transaction or an EIP 712 message intended for the contract.

For more context, you can refer to this video: https://www.youtube.com/watch?v=-O7aX6vUvs8

eip-review-bot commented 2 months ago

File ERCS/erc-7730.md

Requires 1 more reviewers from @axic, @lightclient, @samwilsn

usame-algan commented 2 months ago

Is it in the scope of this EIP on how to handle off-chain data? e.g. some swap transactions merely contain a reference (orderId) to the actual data. So an intent that is purely based on the transaction data might not give the user enough information whereas if the dApp knew what to do with the orderId, more information like the amount or tokens involved in the swap could be displayed.

github-actions[bot] commented 4 days ago

The commit 415b9ad4a69f4e0ffd289eb509b93a2077996fbf (as a parent of feec5c460c82a06f6155602e32f4d07a13bf2989) contains errors. Please inspect the Run Summary for details.