ethereum / ERCs

The Ethereum Request for Comment repository
Creative Commons Zero v1.0 Universal
302 stars 407 forks source link

Add ERC-xxxx #522

Closed 1999321 closed 2 months ago

1999321 commented 2 months ago

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

eip-review-bot commented 2 months ago

🛑 eip-review-bot failed for an unknown reason. Please see logs for more details, and report this issue at the eip-review-bot repository.

gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/workspace/255876/incidents/secrets) | | Alchemy API Key | 154e08ae692adc9b0e753b15cac76e8332305ff2 | assets/erc-xxxx/lib/forge-std/src/StdChains.sol | [View secret](https://github.com/ethereum/ERCs/commit/154e08ae692adc9b0e753b15cac76e8332305ff2#diff-2ab3c67fea3ee491d74f24aa22a6e763c68cf70d17d646cfc02ff79969604814L200) | | [-](https://dashboard.gitguardian.com/workspace/255876/incidents/secrets) | | Alchemy API Key | 154e08ae692adc9b0e753b15cac76e8332305ff2 | assets/erc-xxxx/lib/forge-std/foundry.toml | [View secret](https://github.com/ethereum/ERCs/commit/154e08ae692adc9b0e753b15cac76e8332305ff2#diff-b583274aaf94279780e5404ae1a63c7b9ec40b9416b3f639ce4dfd36a91700eaL6) | | [-](https://dashboard.gitguardian.com/workspace/255876/incidents/secrets) | | Alchemy API Key | 154e08ae692adc9b0e753b15cac76e8332305ff2 | assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol | [View secret](https://github.com/ethereum/ERCs/commit/154e08ae692adc9b0e753b15cac76e8332305ff2#diff-89b7df9d82fd2f38f03aa8600469d1e89ec542a4b56901234e0477e85c614925L27) | | [-](https://dashboard.gitguardian.com/workspace/255876/incidents/secrets) | | Alchemy API Key | 154e08ae692adc9b0e753b15cac76e8332305ff2 | assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol | [View secret](https://github.com/ethereum/ERCs/commit/154e08ae692adc9b0e753b15cac76e8332305ff2#diff-89b7df9d82fd2f38f03aa8600469d1e89ec542a4b56901234e0477e85c614925L39) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/private_key_openssh#revoke-the-secret). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit) to catch secret before it leaves your machine and ease remediation. If this detection is a false positive, please contact Oleh Vasylenko (@aldekein) to fix it in the GitGuardian dashboard.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

github-actions[bot] commented 2 months ago

The commit 154e08ae692adc9b0e753b15cac76e8332305ff2 (as a parent of af75bfd2f9001c99643e36dd375f542b76e76681) contains errors. Please inspect the Run Summary for details.