ethereum / ERCs

The Ethereum Request for Comment repository
Creative Commons Zero v1.0 Universal
302 stars 407 forks source link

Update ERC-6860: Add _blockNumber parameter to Web3 URL specification #547

Open nishuzumi opened 1 month ago

nishuzumi commented 1 month ago

This PR extends the Web3 URL specification to include support for the _blockNumber parameter, allowing users to specify a particular block number when making queries and enabling access to historical blockchain data.

Summary of changes:

eip-review-bot commented 1 month ago

File ERCS/erc-6860.md

Requires 1 more reviewers from @nand2, @pichaoqkc, @qizhou, @samwilsn

github-actions[bot] commented 1 month ago

The commit e81887866a5076aaccf0f0bd2da1a86f7c221d08 (as a parent of 0e763e08768ed779071801a19bab61bfb22db06f) contains errors. Please inspect the Run Summary for details.

nishuzumi commented 1 month ago

@qizhou Add some fix code

nishuzumi commented 1 month ago

The rfc format problem has been fixed after the last modification, please kindly review it again @nand2, @pichaoqkc, @qizhou, @SamWilsn

nand2 commented 1 month ago

Hi!

Thanks for the PR. Here is my feedback :

I would also argue that, while prefixing these attributes with _ makes sense for the manual mode, to prevent conflicts with actual attributes used by the webpage, they are not necessary for the auto mode since there cannot be any conflict. One could argue that it may be confusing that sometimes it is _blockNumber and sometimes it is blockNumber, but on the other hand when we craft a web3:// URL, we already know for which mode we are crafting the URL. So:

What do you think?

Other subject : Outside the scope of this ERC, but linked : for resource request mode (erc-6944), I think we would support this there as well, and it would make sense to me that we just do not forward the new attributes _blockNumber and _gasLimit to the smartcontract. So for the manual mode : should we also extract these from the calldata sent to the smartcontract? It would make sense to me.

Thanks!